Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "binary_image" to receive "scratch" #767

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Allow "binary_image" to receive "scratch" #767

merged 1 commit into from
Jan 22, 2025

Conversation

JAVGan
Copy link
Contributor

@JAVGan JAVGan commented Jan 14, 2025

This commit changes IIB to accept string "scratch" as binary_image in order to support the binaryless build in the future.

With this change IIB accept string "scratch" as binary image:

  • defined in IIB_BINARY_IMAGE_CONFIG
  • passed by binary_image parameter

Refers to CLOUDDST-23094

@JAVGan JAVGan force-pushed the scratch branch 2 times, most recently from 7c9943d to 1b37a06 Compare January 14, 2025 19:41
@JAVGan JAVGan marked this pull request as ready for review January 14, 2025 20:29
@JAVGan JAVGan requested a review from xDaile January 14, 2025 20:30
@JAVGan
Copy link
Contributor Author

JAVGan commented Jan 14, 2025

@release-engineering/exd-guild-hello-operator PTAL

@JAVGan JAVGan changed the title WIP: Allow "binary_image" to receive "scratch" Allow "binary_image" to receive "scratch" Jan 20, 2025
iib/workers/tasks/build.py Outdated Show resolved Hide resolved
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I agree that request should not complete if we are failing for binaryless image in worker

@JAVGan
Copy link
Contributor Author

JAVGan commented Jan 22, 2025

@chandwanitulsi @xDaile I've patched it, PTAL again

This commit changes IIB to accept string "scratch" as `binary_image` in
order to support the binaryless build in the future.

With this change IIB accept string "scratch" as binary image:

- defined in IIB_BINARY_IMAGE_CONFIG
- passed by binary_image parameter

Refers to CLOUDDST-23094
@JAVGan JAVGan merged commit 51b00bd into master Jan 22, 2025
2 checks passed
@JAVGan JAVGan deleted the scratch branch January 22, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants